Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required attribute to input file #755

Merged

Conversation

ProvaTeams
Copy link
Contributor

License Agreement for Contributions

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

Copy link
Member

@Frooodle Frooodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to investigate this, it already has class append logic for required flag in this code with a override flag to not have it

If it's not working I'd rather that be fixed that set required for all file inputs when that may not be the case

@Frooodle Frooodle merged commit c2aaa65 into Stirling-Tools:main Jan 31, 2024
3 checks passed
@sbplat sbplat linked an issue Jan 31, 2024 that may be closed by this pull request
@ProvaTeams ProvaTeams deleted the Add-required-attribute-to-input-file branch February 1, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add required attribute to input file
2 participants