Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Docker - Fonts not copied properly #974

Closed
lawfulsoftware opened this issue Mar 26, 2024 · 1 comment
Closed

Bug - Docker - Fonts not copied properly #974

lawfulsoftware opened this issue Mar 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lawfulsoftware
Copy link

COPY src/main/resources/static/fonts/*.ttf /usr/share/fonts/opentype/noto

COPY src/main/resources/static/fonts/*.otf /usr/share/fonts/opentype/noto

These two lines are supposed to copy fonts from src/main/resources/static/fonts to /usr/share/fonts/opentype/noto/

The contents of the /usr/share/fonts/opentype/ in the Docker container is a single file called noto

I see the following issues:

  1. The src/main/resources/static/fonts directory contains the sub-directory static however the copy command is not recursive.
  2. The copy target is not specified to be a directory; a / should be appended to the end.
  3. The directory should be created prior to copying using RUN mkdir -p
  4. The src/main/resources/static/fonts/ directory does not actually contain any .otf files. The files in that directory are all either .ttf. or .woff2
  5. If the intention is to copy all of the files from the directory, the copy command could be consolidated to COPY src/main/resources/static/fonts/* /usr/share/fonts/opentype/noto/
@sbplat sbplat added the bug Something isn't working label Mar 27, 2024
@Frooodle
Copy link
Member

Missed this issue fixing now to add the /

Frooodle added a commit that referenced this issue Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants