(Sonar) Fix "String#replace
should be preferred to String#replaceAll
"
#1056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remediation
This change fixes the following Sonar rule: "
String#replace
should be preferred toString#replaceAll
" (id = java:S5361)Details
This change replaces
String#replaceAll()
withString#replace()
to enhance performance and avoid confusion.The
String#replaceAll()
call takes a regular expression for the first argument, which is then compiled and used to replace string subsections. However, the argument being passed to it doesn't actually appear to be a regular expression. Therefore, thereplace()
API appears to be a better fit.Our changes look something like this:
More reading
Powered by: pixeebot (codemod ID: sonar:java/substitute-replaceAll-s5361)