Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extends the functionality of oauth in Stirling PDF #1201

Merged
merged 8 commits into from
May 18, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented May 12, 2024

Description

supplements the settings for oauth2, an available claim can be used instead of the email.
The address for the provider is important for Keycloak because the session is not deleted in Keycloak.

Closes #976

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner May 12, 2024 18:07
@Ludy87
Copy link
Contributor Author

Ludy87 commented May 18, 2024

@Frooodle wait!

@Frooodle
Copy link
Member

I shall wait

@Frooodle
Copy link
Member

Taken hands off 😂

@Frooodle
Copy link
Member

Not broken is it? 😂

@Ludy87
Copy link
Contributor Author

Ludy87 commented May 18, 2024

something broken in the design

@Frooodle
Copy link
Member

Good to go?

@Ludy87
Copy link
Contributor Author

Ludy87 commented May 18, 2024

For me, yes, but for you I don't know 😅

@Frooodle Frooodle merged commit 6fc9a20 into Stirling-Tools:main May 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial username is not handled correctly if invalid format
2 participants