Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Serbian (Latin) Language #655

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Adding Serbian (Latin) Language #655

merged 5 commits into from
Jan 4, 2024

Conversation

92mn
Copy link
Contributor

@92mn 92mn commented Jan 4, 2024

Added flag, dropdown menu selection and translation to Serbian.
Now i maybe messed up some \n ( i have checked total number of lines of original code and mine and they are different for about few lines ). If you find that i have missed something, tell me and i will fix it right away.

License Agreement for Contributions

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

Added Serbian ( Latin )
Added Serbian flag
Added Serbian Latin translation
@92mn 92mn requested a review from Frooodle as a code owner January 4, 2024 16:31
@Frooodle
Copy link
Member

Frooodle commented Jan 4, 2024

Looking at
https://localizely.com/language-code/sr/

the code should be
sr-Latn

or
sr-Latn-RS

@92mn
Copy link
Contributor Author

92mn commented Jan 4, 2024

In languages.html it already is sr-Latn-RS and i have changed the .properties file now. Is there anything else that i have missed ?

@Frooodle
Copy link
Member

Frooodle commented Jan 4, 2024

All good :)

@Frooodle Frooodle merged commit 10cb020 into Stirling-Tools:main Jan 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants