Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError by rotation #890

Merged
merged 1 commit into from Mar 9, 2024
Merged

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Mar 9, 2024

Description

Fixes the error in the PDF multitool when rotating all pages at the same time.

PdfContainer.js:182
Uncaught TypeError: this.pagesContainer.childNodes[i].querySelector is not a function
    at PdfContainer.rotateAll (PdfContainer.js:182:53)
    at HTMLButtonElement.onclick (multi-tool:679:100)

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

Fixes the error in the PDF multitool when rotating all pages at the same time.
@Ludy87 Ludy87 requested a review from Frooodle as a code owner March 9, 2024 10:13
@Frooodle Frooodle merged commit 82c4e9c into Stirling-Tools:main Mar 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants