Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DependencyGraph usage #57

Open
StjerneIdioten opened this issue Aug 22, 2020 · 2 comments
Open

Optimize DependencyGraph usage #57

StjerneIdioten opened this issue Aug 22, 2020 · 2 comments
Labels
optimization Optimization of existing code/feature Similar issue exists This issue is similar to an already existing issue, but doesn't add enough value to be standalone.

Comments

@StjerneIdioten
Copy link
Owner

Describe the bug
Back when the code for exporting meshes was first implemented, blender 2.8 was still very new and the documentation for their new usage of dp's(dependencygraphs) was very sparse.

Their current documentation is much more thorough and presents a few possibilities for optimizing the usage of the dp's during export. Especially how the dp is currently created from scratch for each shape object exported and the way that the addon doesn't pull from the dependency graph when selecting export objects.

Relates a bit to #56
@StjerneIdioten StjerneIdioten added optimization Optimization of existing code/feature Similar issue exists This issue is similar to an already existing issue, but doesn't add enough value to be standalone. labels Aug 22, 2020
@StjerneIdioten StjerneIdioten changed the title Reeimplement dependencygraph utilization Optimize DependencyGraph usage Aug 22, 2020
@StjerneIdioten
Copy link
Owner Author

ec90c35 Touches upon this a bit, but I would like even further optimizations to take place. Especially in regards to refering blender objects directly instead of going through the dependency graph or object list everytime.

StjerneIdioten added a commit that referenced this issue Aug 23, 2020
@StjerneIdioten
Fix a bug with dangling nodes in the node_tree of materials. Deleted …
208d80f 
…nodes got exported as well. The bug has surfaced because of fixes implemented in relation to #56, which in terms stem from issues in blender described in #57. This is hopefully a temporary fix until blender fixes their api
@StjerneIdioten
Copy link
Owner Author

After some further bugs have arisen and some testing. I have concluded that something is wrong with blenders dependency graph, or at least the option preserve_all_data_layers=True of the obj.to_mesh() function.
I did some searching and came across this active bug on the blender issue tracker.

I have implemented a workaround in 208d80f untill blender fixes this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimization Optimization of existing code/feature Similar issue exists This issue is similar to an already existing issue, but doesn't add enough value to be standalone.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StjerneIdioten