Changes to how you add shaders in the UI #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an early return check for the shader's variation. If the selected variation is the same as the previously active one, the function exits early, preventing any unnecessary resetting of shader parameters. Fix StjerneIdioten#180
- The shaders will now be automatically loaded in a EnumProperty through the data path set in addon preferences - This includes a operator that will migrate the old "source" property over to the new "shader" enum property (and preserve all the other shader related data) - Made it possible to add "material_name" to the load_shader and load_shader_variation operators so it can be called through API without needing to have a active object with a active material to run the operators
merge dev inte shader-fixes
|
Guess this would also fix #170 |
StjerneIdioten
changed the base branch from
develop
to
feat/185/shader_pr_cleanup
StjerneIdioten
pushed a commit
that referenced
this pull request
Feb 16, 2024
* fix(shader): Prevent resetting parameters in shader settings Introduce an early return check for the shader's variation. If the selected variation is the same as the previously active one, the function exits early, preventing any unnecessary resetting of shader parameters. Fix #180 * feat(material): New way of adding shaders - The shaders will now be automatically loaded in a EnumProperty through the data path set in addon preferences - This includes a operator that will migrate the old "source" property over to the new "shader" enum property (and preserve all the other shader related data) - Made it possible to add "material_name" to the load_shader and load_shader_variation operators so it can be called through API without needing to have a active object with a active material to run the operators * Added support to export new shader setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should hopefully fix #179