Issue 69 #70
Merged
Issue 69 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
beshur
commented
Feb 12, 2017
beshur
commented
- Updated options saving mechanism - no localStorage no more for providers - only chrome.storage
- Misc refactoring
endway
reviewed
Feb 13, 2017
background.js
Outdated
| } | ||
|
|
||
| // Get options from chrome.storage.sync. | ||
| function restore_options(callback) { |
content.js
Outdated
| } | ||
|
|
||
| }); | ||
| this.allowed = allowed; |
There was a problem hiding this comment.
providers.filter(provider => provider.enabled).map(provider => provider.uri)
options.js
Outdated
| for (var i = 0; i < providersCurrent.length; i++) { | ||
| providersCurrent[i]['enabled'] = toggler; | ||
| providersCurrent = providersCurrent.map(function(item) { | ||
| return item.enabled = toggler; |
There was a problem hiding this comment.
Разве это не boolean возвращает?
There was a problem hiding this comment.
переназначает всем элементам enabled на toggler
There was a problem hiding this comment.
я к тому, что после этого мапа providersCurrent будет массив boolean
There was a problem hiding this comment.
гм, но как тогда оно работает? я посмотрю позже
beshur
commented
Feb 14, 2017
background.js
Outdated
| } | ||
|
|
||
| // Get options from chrome.storage.sync. | ||
| function restore_options(callback) { |
options.js
Outdated
| for (var i = 0; i < providersCurrent.length; i++) { | ||
| providersCurrent[i]['enabled'] = toggler; | ||
| providersCurrent = providersCurrent.map(function(item) { | ||
| return item.enabled = toggler; |
There was a problem hiding this comment.
гм, но как тогда оно работает? я посмотрю позже
endway
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.