Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/readme #40

Merged
merged 28 commits into from Jan 22, 2022
Merged

Docs/readme #40

merged 28 commits into from Jan 22, 2022

Conversation

mdip226
Copy link
Collaborator

@mdip226 mdip226 commented Nov 11, 2021

No description provided.

@mdip226 mdip226 added the documentation Improvements or additions to documentation label Nov 11, 2021
@mdip226 mdip226 added this to the 0.9 milestone Nov 11, 2021
@mdip226 mdip226 self-assigned this Nov 11, 2021
@mdip226 mdip226 added this to In Progress in Release v0.9 via automation Nov 11, 2021
@mdip226 mdip226 linked an issue Nov 11, 2021 that may be closed by this pull request
@mdip226 mdip226 linked an issue Nov 18, 2021 that may be closed by this pull request
@briandrawert briandrawert self-requested a review November 19, 2021 20:18
@briandrawert briandrawert marked this pull request as ready for review November 19, 2021 20:27
@briandrawert briandrawert moved this from In Progress to Awaiting Review in Release v0.9 Nov 19, 2021
@briandrawert briandrawert linked an issue Nov 20, 2021 that may be closed by this pull request
@briandrawert
Copy link
Member

I was not able to successfully follow the readme. See #47

Copy link
Collaborator

@ethangreen-dev ethangreen-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work so far, just needs a couple additions / changes and it'll be perfect.

# StochSS-Compute

With StochSS-Compute, you can run GillesPy2 simulations on your own server. Results are cached and anonymized, so you
can easily save and recall previous simulations.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this with something for generic (as GillesPy2 is just the start). Maybe something like this "A distributed compute delegation server for the StochSS family of stochastic simulators."?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was gonna do that but then I just figured to wait until that's fully implemented

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but yeah, i agree with what you said

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
stochss_compute/api/delegate/dask_delegate.py Outdated Show resolved Hide resolved
Copy link
Member

@briandrawert briandrawert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I walked through the README, I got the error in #58

@briandrawert
Copy link
Member

Merge #52 before merging this PR

@briandrawert briandrawert merged commit dcc53d6 into dev Jan 22, 2022
Release v0.9 automation moved this from Awaiting Review to Done Jan 22, 2022
@briandrawert briandrawert deleted the docs/readme branch January 22, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Release v0.9
  
Done
Development

Successfully merging this pull request may close these issues.

JSONDecodeError Need Example usage notebooks Update README.md to reflect overall infrastructure changes
3 participants