Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 control support package added #12

Open
wants to merge 47 commits into
base: rolling
Choose a base branch
from

Conversation

Robotgir
Copy link

No description provided.

@Robotgir Robotgir closed this Mar 6, 2023
@Robotgir Robotgir reopened this Mar 11, 2023
@destogl destogl mentioned this pull request Mar 27, 2023
Co-authored-by: muritane <31107191+muritane@users.noreply.github.com>
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@destogl
Copy link
Member

destogl commented Mar 27, 2023

@muritane you created a script for testing this, didn't you?

Can we attach this?

use_mock_hardware:=^|false
sim_gazebo_classic:=^|false
sim_gazebo:=^|false
simulation_controllers
robot_description_package"
>

<xacro:property name="initial_positions" value="${load_yaml(initial_positions_file)['initial_positions']}"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also utilize this agument lower under initial_value tag

ros2 launch kuka_ros2_control_support test_ros2_control_kuka.launch.py robot_description_package:=kuka_kr16_support robot_description_macro_file:=kr16_2_macro.xacro robot_name:=kuka_kr16_2 controllers_file:=kuka_6dof_controllers.yaml

```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -1,66 +1,83 @@
cmake_minimum_required(VERSION 3.1.0)
cmake_minimum_required(VERSION 3.5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmake_minimum_required(VERSION 3.5)
cmake_minimum_required(VERSION 3.16)

gwalck and others added 5 commits June 4, 2023 14:06
Due to many robots with tip at various poses,
the test verifies only if the tool0 frame
can be resolved and is non-null
With the listener within the main class,
strange wait_for_message issues arise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants