Adding kuka210r3100 robot foxy #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muritane
reviewed
Mar 16, 2023
|
|
||
| <xacro:include filename="$(find kuka_kr210_support)/urdf/kr210r3100_macro.xacro"/> | ||
|
|
||
| <xacro:kuka_kr210r3100 prefix=""/> |
There was a problem hiding this comment.
should the prefix arg be used here?
<xacro:kuka_kr210r3100 prefix="$(arg prefix)"/>
There was a problem hiding this comment.
Suggested change
| <xacro:kuka_kr210r3100 prefix=""/> | |
| <xacro:kuka_kr210r3100 prefix="$(arg prefix)"/> |
muritane
reviewed
Mar 16, 2023
| @@ -121,6 +121,8 @@ ROS2 Distro | Branch | Build status | Documentation | Released packages | |||
| "kr150_2_macro.xacro", | |||
| "kr150r3100_2_macro.xacro", | |||
| "kr210l150_macro.xacro", | |||
| "kr210r3100_macro.xacro", | |||
| "lbr_iiwa_14_r820_macro.xacro", | |||
There was a problem hiding this comment.
why is this "lbr_iiwa_14_r820_macro.xacro" here? it is a little bit confusing as the pr name is only about adding kuka210r3100 (maybe it is just pedantic)
muritane
reviewed
Mar 16, 2023
| @@ -137,6 +139,8 @@ ROS2 Distro | Branch | Build status | Documentation | Released packages | |||
| "kuka_kr150_2", | |||
| "kuka_kr150r3100_2", | |||
| "kuka_kr210l150", | |||
| "kuka_kr210r3100", | |||
| "kuka_lbr_iiwa_14_r820", | |||
|
testing in rviz (docker foxy) works for me: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.