-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this._data is never set when without hooks path is taken in transition_impl
#557
Comments
Sorry, took me a second to see this. In the future, I'll see it faster if you use the unified tracker. I'm now trying to think my way through this problem. |
Confirmed. Resolution will continue on StoneCypher/fsl#1259 Thank you, @WNemencha |
data arg2 wasn't implemted; only data argument in hooks. implemented; added 26 tests to control. fixes #557; fixes StoneCypher/fsl#1259
You were right that the call pattern had to be implemented without hooks, but I also had to implement the call pattern with hooks. This led to noticing that at this time, there is also no way practical way to set
Thank you, @WNemencha , for improving this state machine. I apologize for this oversight. |
jssm/src/ts/jssm.ts
Lines 2362 to 2380 in 7de448c
Code in this extract should change to something like:
+ this._data = newData || this._data; // or better logic not sure about this. if (this._history_length) { this._history.shove([ this._state, this._data ]); } this._state = newState;
otherwise when not using hooks, and calling
.data()
it always return null, also data does not appears in history.The text was updated successfully, but these errors were encountered: