Icicle Burst can now only be played when enemy units were frozen this turn #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
388
to
390
| if (newState.specifics.potentialFrozenEnemiesInAColumn) { | ||
| newState.specifics.potentialFrozenEnemiesInAColumn = 0 | ||
| } |
There was a problem hiding this comment.
You can skip the condition entirely here and simply reassign:
newState.specifics.potentialFrozenEnemiesInAColumn = 0There was a problem hiding this comment.
I wanted to keep it consistent with the Frozen Core test which reassigns mana only when it's not equal to 0, even though the test could be removed. It's probably better to remove both though
Comment on lines
141
to
152
| case 'W2': | ||
| // Frosthexers | ||
| newState.specifics.potentialFrozenEnemiesInAColumn += 2 | ||
| break | ||
| case 'W6': | ||
| // Moment's Peace | ||
| newState.specifics.potentialFrozenEnemiesInAColumn += 3 | ||
| break | ||
| case 'W11': | ||
| // Midwinter Chaos | ||
| newState.specifics.potentialFrozenEnemiesInAColumn += 4 | ||
| break |
There was a problem hiding this comment.
I’m not sure how much value there is in counting enemies. Maybe we could simplify it like this:
case 'W2':
case 'W6':
case 'W11':
newState.specifics.potentiallyFrozenUnits = true
breakThere was a problem hiding this comment.
I was planning to implement Zhevana's ability after - that's why I'm only counting in a column
KittySparkles
approved these changes
Apr 23, 2020
| @@ -20,8 +20,12 @@ export default class DeckMechanisms extends React.Component { | |||
| hand: [], | |||
| RNG: 'REGULAR', | |||
| hasCycledThisTurn: false, | |||
| noUnitsOnFirstTurn: true, | |||
There was a problem hiding this comment.
Good thinking to move it in specifics. Way better. :)
Co-Authored-By: Kitty <53430374+KittySparkles@users.noreply.github.com>
KittySparkles
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.