Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #111

Merged
merged 21 commits into from
Oct 20, 2023
Merged

Update dependencies #111

merged 21 commits into from
Oct 20, 2023

Conversation

oeb25
Copy link
Collaborator

@oeb25 oeb25 commented Oct 17, 2023

This PR updates a lot of the dependencies to their latest version.

Honorable mentions are:

I've held back on updating safetensors, tch, and tokenizers as I'm not confident in testing whether updating these cause issues or not. Other than those three crates, everything should be up-to-date!


This was done as an attempt to reduce compile times, and as a huge success (/s) I can confirm that this reduces the number of LLVM lines generated by 4056, which equates to a 0.30983876% decrease!


Benchmarking incremental build times, where only core/src/lib.rs changes, we see little to no difference:

git switch main && cargo build -p stract --bin stract
  Time (mean ± σ):      7.700 s ±  0.081 s    [User: 7.090 s, System: 1.918 s]
  Range (min … max):    7.569 s …  7.855 s    10 runs

git switch update-deps && cargo build -p stract --bin stract
  Time (mean ± σ):      7.837 s ±  0.145 s    [User: 7.301 s, System: 1.948 s]
  Range (min … max):    7.706 s …  8.149 s    10 runs

Summary
  'git switch main && cargo build -p stract --bin stract' ran
    1.02 ± 0.02 times faster than 'git switch update-deps && cargo build -p stract --bin stract'

@oeb25 oeb25 marked this pull request as draft October 17, 2023 13:37
@oeb25 oeb25 force-pushed the update-deps branch 2 times, most recently from 3b4af03 to 6ae735c Compare October 17, 2023 14:25
@Lorak-mmk
Copy link

I think now that we merged your fix to Scylla driver, you don't need to use a fork, you could use our main branch, no?

@oeb25
Copy link
Collaborator Author

oeb25 commented Oct 18, 2023

Totally @Lorak-mmk!

With that, I think we are ready to merge this!

@oeb25 oeb25 marked this pull request as ready for review October 18, 2023 08:56
This one required a bit of tweeking as one must now select which engine
to use.

Since the alice engine is used across modules, it exposes its engine,
while entity index only uses its encoding internally, and thus does not
re-export it.
This was a bigger one, since the API has changed a bit.

For some, it has become simpler to get at the bytes, such as no longer
needing to decode with a reader.
It was not used directly, but is used indirectly by tch, so there is no
need to declare it explicitly.
We still need to change it to the latest crates.io version when that
gets released!
@mikkeldenker mikkeldenker merged commit 16fa91a into main Oct 20, 2023
1 check passed
@oeb25 oeb25 deleted the update-deps branch December 28, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants