feat: Make loading from an external URL be gated behind a feature. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2aaron
force-pushed
the
http-feature
branch
2 times, most recently
from
caa9210
to
e6a2cad
Compare
|
Hm, it looks like the python bindings are failing? I'm not quite as familiar with that stuff, so I might need some help fixing that up. |
|
Ah I see, the bindings just need to have the feature active. There is also a weird failure with |
a2aaron
changed the title
|
Thank you for making this PR! Could you, please, rebase? The Python issue is resolved in 0d5311c |
`attohttpc` and its transitive dependencies add a large amount of size to the crate (on the order of about ~400 kB). For applications which don't need external URL loading and are concerned with code size (for example, a WASM binary), this is wasted space. Placing this stuff behind a feature gate allows people to opt-out and reduce code size if they wish.
I'm assumining that these bindings expect `http` to be active. Having `default_features` be false meant that these bindings weren't getting the `http` gated code.
|
Done! |
|
Awesome! Thanks :) Re: the file loading feature - I think it also makes complete sense to have such a feature (it could be named |
Sure, I can add that real quick. I've opened a PR at #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attohttpcand its transitive dependencies add a large amount of size to the crate (on the order of about ~400 kB, or about 70 kB when compressed). For applications which don't need external URL loading and are concerned with code size (for example, a WASM binary), this is wasted space. Placing this stuff behind a feature gate allows people to opt-out and reduce code size if they wish.Note that this doesn't disable loading stylesheets from a local file. It might be worth it to add a feature (something like
fs) that also gates that functionality (as this also adds a decent amount of size--about 100 kB compressed and around 500 kB uncompressed). I could pretty easily add this functionality, if desired (I have this functionality on a2aaron:minimal right now).