Dedup stylesheet href #90
Conversation
Dearest Maintainer, First thank you for your work on this project. I am comparing this to the Roadie gem for ruby. It inlines css into html emails. I have a really fun email that keeps including a script tag. The same dup script tag. I have updated your code to dedup the hrefs you are loading. Thanks again. Your command line tool takes 3.1 seconds where the Roadie gem takes about 2 minutes. Dictated but not reviewed, Becker
I noticed the clippy error in the pr.
src/lib.rs
Outdated
| .borrow() | ||
| .get("href") | ||
| .as_ref() | ||
| .unwrap() |
There was a problem hiding this comment.
yes this need to handle it not being there.
There was a problem hiding this comment.
Hi @sbeckeriv
Cool! Thank you for your contribution :) I left some performance-related comments (minor ones, though)
Wow! That is great! :) |
|
I will merge it as is and then apply some performance tweaks :) |
|
Suggestions looks good. It has been a busy few days. Thanks for merging and applying. Should the node built be passing? I could not figure that out. |
Yep, this one is quite strange, probably it might be caused by some WASM-related dependency updates, but the TypeScript tests pass, which is good enough to make a new release :) I'll look at the issue later |
Dearest Maintainer,
First thank you for your work on this project. I am comparing this to
the Roadie gem for ruby. It inlines css into html emails. I have a
really fun email that keeps including a script tag. The same dup script
tag. I have updated your code to dedup the hrefs you are loading.
Thanks again. Your command line tool takes 3.1 seconds where the
Roadie gem takes about 2 minutes.
Dictated but not reviewed,
Becker