Set default-features=false for reqwest #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes Stranger6667#335 . Otherwise, reqwest will always use default-tls which is the native-tls even if jsonschema `reqwest-rustls-tls` feature is specified.
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 57 57
Lines 5514 5514
=======================================
Hits 4563 4563
Misses 951 951 Continue to review full report at Codecov.
|
jqnatividad
added a commit
to jqnatividad/qsv
that referenced
this pull request
Jan 23, 2022
as it will not work with jsonschema 0.13.3, which pulls in openssl. The fix has been accepted (yay!) Stranger6667/jsonschema-rs#336 but until the next version of jsonschema is published, let's not cross-compile for other platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #335 .
Otherwise, reqwest will always use default-tls which is the native-tls even if jsonschema
reqwest-rustls-tlsfeature is specified.