feat(python): support validation of dict subclasses #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, attemping to validate an instance of a dict subclass will raise a `ValueError`. This should not be happening, since the instance is still dict. Achieve compatibility by checking the subclasses' inheritance tree, and treat the instance like a dict if that check passes.
|
Thank you! It looks good to me, will check it in more details during the weekend |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 79.48% 79.48%
=======================================
Files 56 56
Lines 5122 5122
=======================================
Hits 4071 4071
Misses 1051 1051 ☔ View full report in Codecov by Sentry. |
Stranger6667
approved these changes
Mar 22, 2024
|
Thank you so much! I'll issue a new release shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: This is a low-confidence PR as I have zero experience with Rust and the pyo3 library. Feel free to be hard on me :)
Currently, attempting to validate an instance of a dict subclass will raise a
ValueError. This should not be happening, since the instance is still dict. Achieve compatibility by checking the instance's inheritance tree, and treat the instance like a dict if that check passes.Resolves #427