Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle errors instead of unwrap #73

Merged
merged 1 commit into from May 21, 2020
Merged

Conversation

Stranger6667
Copy link
Owner

Fixes #65

Closes #20

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #73 into master will decrease coverage by 0.65%.
The diff coverage is 34.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   82.52%   81.87%   -0.66%     
==========================================
  Files          45       45              
  Lines        3204     3227      +23     
==========================================
- Hits         2644     2642       -2     
- Misses        560      585      +25     
Impacted Files Coverage Δ
src/error.rs 59.90% <0.00%> (-5.19%) ⬇️
src/lib.rs 17.77% <ø> (+0.19%) ⬆️
src/resolver.rs 78.92% <85.71%> (+2.12%) ⬆️
src/compilation.rs 91.66% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc40f1...c7d5286. Read the comment docs.

@Stranger6667 Stranger6667 merged commit 4cf7d8d into master May 21, 2020
@Stranger6667 Stranger6667 deleted the dd/avoid-unwrap branch May 21, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle errors instead unwrap Cleanup folders joining in resolve_fragment
1 participant