Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claim, edit profile, and FTX pay to extension #10

Merged
merged 8 commits into from
Aug 3, 2021

Conversation

ChewingGlass
Copy link
Collaborator

No description provided.

Comment on lines +95 to +99
onClick={() => {
const twitterHandleSanitized = twitterHandle.replace("@", "");
claim(twitterHandleSanitized)
.then(() => create(twitterHandleSanitized))
.then(onComplete);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about errors?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these are useAsyncCallback functions, so errors should come from the hook

className="mt-2"
color="primary"
submit
// className="inline-flex justify-center py-2 px-4 border border-transparent shadow-sm text-sm font-medium rounded-md text-white bg-indigo-600 hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this?

@ChewingGlass ChewingGlass merged commit 59f9984 into master Aug 3, 2021
@bryzettler bryzettler deleted the feature/extension-claim branch August 19, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants