-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: PBR shader incorrectly gets lit by lights when viewmodel is drawn #993
Comments
Side note: There are a couple light_spot entities. That is intentional, I was testing to see if lighting bug works on those. For some reason, it does not |
I highly recommend to share here your |
isnt vertexlitgeneric only supposed to be used with models? |
no but your issue show similar results, I have an idea that you maybe just have problem in your vmt file. |
Created straight from PBR-2-Source, with only the parallax params noportal flag being added |
Fixed in staging |
Describe the bug
The PBR shader does not light correctly when the ViewModel is drawn, producing vastly incorrect lighting. This effect is greatly amplified when using the light from the skybox when CSM does not exist.
It seems to be tied to the lighting of the ViewModel for some reason, as the color fading effect on the ViewModel also seems to affect the PBR materials:
https://github.com/StrataSource/Engine/assets/113145248/22c7c729-0a19-42ee-ba84-988a0cb6d4f2
Here are some example screenshots:
![20231103200820_1](https://private-user-images.githubusercontent.com/113145248/280442438-5774552a-be3c-4ac4-b18f-22d4ec76b00d.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNDM4LTU3NzQ1NTJhLWJlM2MtNGFjNC1iMThmLTIyZDRlYzc2YjAwZC5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05YWUyMTZiMjVkMzM2MzU0MWMxMjNmMTU4ZTUyOTE5YzA4MTYzODIwNDM2NTE3NDdlNWI3NTMxYjUwYTRhZjlhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.HxOOKBJbpFSYriK7z3_-7oEOc0NIShPqatL2pvi57jE)
![20231103200824_1](https://private-user-images.githubusercontent.com/113145248/280442442-49930c46-36d9-4f2d-ae31-3975361692ec.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNDQyLTQ5OTMwYzQ2LTM2ZDktNGYyZC1hZTMxLTM5NzUzNjE2OTJlYy5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ODY5YjU3ZGVkZWZjYjkzZTk0NzJkOTQ5MzM1NTY0MmFkY2FmMDU1MTI3YjMwMWUxYzQxZTFmOWMyYTI0Y2Y1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.LsjR13Pwdc-VPesVudcnAuO9j9fnB5Y_2_05bnq3UcI)
![20231103200833_1](https://private-user-images.githubusercontent.com/113145248/280442445-0eca7293-d6b6-49e1-9f47-d827e81381eb.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNDQ1LTBlY2E3MjkzLWQ2YjYtNDllMS05ZjQ3LWQ4MjdlODEzODFlYi5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYmI1ZmY3NzRlMWQ5ZmViM2MzYmNhNjJiYTVmZWVmYTQyYzg3ZDdiMmE4NmQ4ZDdmYjZjZDE5ZGNjMTdhYzg5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.GdMsX71gsNSvqIu8blfSUVkMEwGzai7ALuWVrKmrRgs)
![20231103200835_1](https://private-user-images.githubusercontent.com/113145248/280442447-0d4e06ca-5388-4bdc-b7ed-31aadc18bc97.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNDQ3LTBkNGUwNmNhLTUzODgtNGJkYy1iN2VkLTMxYWFkYzE4YmM5Ny5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kZjczNWMzMDJiZTdhNzJmMjFmYmU3YzJjZTEzMGZiZDJhZmM4Y2I5ODUxOWRkMzE5MjdmMzBlYjI0ZTRiNTlmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.BKsrkI8VmZB0CAH8ZcoWLftz9wUKmAjlxu9vY9YM11g)
![20231103201108_1](https://private-user-images.githubusercontent.com/113145248/280442448-e68060ff-7350-4e60-a508-a3ac1dc0bb5c.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNDQ4LWU2ODA2MGZmLTczNTAtNGU2MC1hNTA4LWEzYWMxZGMwYmI1Yy5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NmQzMmNlYWZlNWYzNGI3Y2RjMDcwMGY0Mjg3MjY4YTdjOWNmMTA4OWM1NWViZmI0NDYzODIzMmY0YTgwZDQzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.S0S5uIH74qZV2_LV6bQToNCd_ZCv73PxlmhqwvxUNVc)
![20231103201110_1](https://private-user-images.githubusercontent.com/113145248/280442451-c7405df5-94cd-479e-8e9f-9068148d580b.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNDUxLWM3NDA1ZGY1LTk0Y2QtNDc5ZS04ZTlmLTkwNjgxNDhkNTgwYi5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lMWE0NDY3ODNkOWMyMDIxM2ZiZTM0MjFkNmM5YWMzNWRmODMxY2FlZGRlNWZlN2Y1NDQ3NWFlZDViYmU5YWI5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.swVTqvCYNhPhTSF-01QXsNdF5QCfrPfNzdIixovDuzU)
![20231103201902_1](https://private-user-images.githubusercontent.com/113145248/280442564-77b488cf-7d16-4ce9-b73c-baf971ceaaad.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNTY0LTc3YjQ4OGNmLTdkMTYtNGNlOS1iNzNjLWJhZjk3MWNlYWFhZC5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lOTVkMDEwMDIwZTZhNWI2MDk1MWM4MmY0N2Y4YWMxMDkzODkxZTk4MTJlYTg0MDkyZDBkNDMwMzUyZTUxZTQ0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.2RFHSM4L9hBE6imHIhrylkTOuYZIJuTCI3lU26N_CBY)
![20231103201904_1](https://private-user-images.githubusercontent.com/113145248/280442565-43127eea-fbfd-404a-a17a-a28a9e7c21e9.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NjY0MDgsIm5iZiI6MTcyMTU2NjEwOCwicGF0aCI6Ii8xMTMxNDUyNDgvMjgwNDQyNTY1LTQzMTI3ZWVhLWZiZmQtNDA0YS1hMTdhLWEyOGE5ZTdjMjFlOS5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMVQxMjQ4MjhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04MGNhNGIzOTc4ZTE2NGE3ZWJlNTQ2MDE5OTliYjI5Njg2NzBmMjcxMzY4ZjFhOTlmM2UxNWUzNTQ0MDNlZWJmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.S2eg8mmneNe4vsmMMUCodzexAun-_2JJzUMrdWoUcF4)
To Reproduce
ent_remove env_cascade_light
)Then repeat this with the ViewModel disabled
Issue Map
pbr_light_test.zip
Expected Behavior
lighting should remain consistent when viewmodel interacts with
Operating System
Tested on Windows 11
The text was updated successfully, but these errors were encountered: