Skip to content

Commit

Permalink
Add phpdoc to non-static public methods
Browse files Browse the repository at this point in the history
  • Loading branch information
Stratadox committed Apr 16, 2018
1 parent ae747d4 commit b80a88f
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/AlterableCollectionEntryUpdater.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ public static function forThe(
return new static($owner, $ofTheProperty, $atPosition, $setter);
}

/** @inheritdoc */
public function updateWith($theLoadedInstance): void
{
$this->setter->call($this->owner,
Expand Down
5 changes: 4 additions & 1 deletion src/AlterableCollectionEntryUpdaterFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
*/
final class AlterableCollectionEntryUpdaterFactory implements ProducesOwnerUpdaters
{
// @todo allow passing the closure
/**
* @inheritdoc
* @todo allow passing the closure
*/
public function makeUpdaterFor(
$owner,
string $ofTheProperty,
Expand Down
1 change: 1 addition & 0 deletions src/ArrayEntryUpdater.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public static function forThe(
return new static($owner, $ofTheProperty, $atPosition, $setter);
}

/** @inheritdoc */
public function updateWith($theLoadedInstance): void
{
$this->setter->call($this->owner,
Expand Down
5 changes: 4 additions & 1 deletion src/ArrayEntryUpdaterFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
*/
final class ArrayEntryUpdaterFactory implements ProducesOwnerUpdaters
{
// @todo allow passing the closure
/**
* @inheritdoc
* @todo allow passing the closure
*/
public function makeUpdaterFor(
$owner,
string $ofTheProperty,
Expand Down
3 changes: 3 additions & 0 deletions src/Loader.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,19 @@ public function __construct($forWhom, string $property, $position = null)
$this->position = $position;
}

/** @inheritdoc */
public function attach(ObservesProxyLoading $observer): void
{
$this->observers[] = $observer;
}

/** @inheritdoc */
public function detach(ObservesProxyLoading $observer): void
{
unset($this->observers[array_search($observer, $this->observers)]);
}

/** @inheritdoc */
final public function loadTheInstance()
{
$instance = $this->doLoad($this->forWhom, $this->property, $this->position);
Expand Down
1 change: 1 addition & 0 deletions src/PropertyUpdater.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public static function forThe(
return new static($owner, $ofTheProperty, $setter);
}

/** @inheritdoc */
public function updateWith($theLoadedInstance): void
{
$this->setter->call($this->owner,
Expand Down
5 changes: 4 additions & 1 deletion src/PropertyUpdaterFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
*/
final class PropertyUpdaterFactory implements ProducesOwnerUpdaters
{
// @todo allow passing the closure
/**
* @inheritdoc
* @todo allow passing the closure
*/
public function makeUpdaterFor(
$owner,
string $ofTheProperty,
Expand Down
1 change: 1 addition & 0 deletions src/ProxyFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public static function fromThis(
return new static($proxies, $loaderFactory, $updaterFactory);
}

/** @inheritdoc */
public function createFor(
$theOwner,
string $ofTheProperty,
Expand Down
2 changes: 1 addition & 1 deletion src/Proxying.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ trait Proxying
/** @var object|null */
private $instance;

/** @return self */
/** @return static */
public function __load()
{
if (!$this->loader instanceof LoadsProxiedObjects) {
Expand Down

0 comments on commit b80a88f

Please sign in to comment.