Skip to content
This repository has been archived by the owner on May 27, 2020. It is now read-only.

fix parsing parameter #127

Open
wants to merge 6 commits into
base: branch-0.11
Choose a base branch
from
Open

fix parsing parameter #127

wants to merge 6 commits into from

Conversation

wuciawe
Copy link
Contributor

@wuciawe wuciawe commented Apr 28, 2016

It resolves #126 and related parsing problems, #112 and #119 .

@wuciawe
Copy link
Contributor Author

wuciawe commented Apr 28, 2016

I find that this is related with #112 again. And I think maybe it's necessary to add more tests, and unify the access to properties. All the accesses should be limited with the access provided by com.stratio.datasource.util.Config.

@wuciawe
Copy link
Contributor Author

wuciawe commented Apr 29, 2016

I realized that it requires more changes. I'm working on this problem.

@wuciawe
Copy link
Contributor Author

wuciawe commented Apr 29, 2016

I hope this time there will be no more paring problems, and I try my best to keep the original structure. In the com.stratio.datasource.mongodb.client.MongodbClientFactoryTest, I changed the way to init configurations since I think it's good to init configuration only from MongodbConfigBuilder and the old short cut way is imcompatitable with the new change. @pfcoperez plz check this pull request, it passes the current project tests, but I'm not very sure it covers all the problems, maybe need more tests and documentation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant