Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tag format as utf-8 instead of byte #164

Merged
merged 3 commits into from Aug 2, 2023
Merged

fix tag format as utf-8 instead of byte #164

merged 3 commits into from Aug 2, 2023

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Jul 30, 2023

git.get_hash() return's bytes instead of string
https://github.com/Stratoscale/skipper/blob/upstream/skipper/git.py#L19

fix #163

@eifrach
Copy link
Contributor Author

eifrach commented Jul 31, 2023

@eranco74 - can you please review

@eifrach
Copy link
Contributor Author

eifrach commented Aug 2, 2023

@eranco74 /retest please :)

eranco74
eranco74 reviewed Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@eranco74 eranco74 merged commit 4ba1c9e into Stratoscale:upstream Aug 2, 2023
3 checks passed
@eifrach eifrach deleted the decodefix branch August 2, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranco74 eranco74 eranco74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't build skipper (skipper build cmd) with v2.0.0 and v2.0.1
2 participants
@eifrach @eranco74