Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors and warnings issued by Rider #72

Closed
colinangusmackay opened this issue Jan 9, 2021 · 1 comment
Closed

Fix errors and warnings issued by Rider #72

colinangusmackay opened this issue Jan 9, 2021 · 1 comment

Comments

@colinangusmackay
Copy link
Member

Solution Gedcom.sln
    Project Stravaig.FamilyTree.Blazor
      Stravaig.FamilyTree.Blazor\Pages\Index.razor:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Blazor\Pages\Index.razor:22 Empty statement is redundant
      Stravaig.FamilyTree.Blazor\Program.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Blazor\Program.cs:5 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Blazor\Program.cs:7 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Blazor\Program.cs:9 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Blazor\Shared\Relationship.razor:10 Name '_relationshipRenderer' does not match rule 'Properties'. Suggested name is 'RelationshipRenderer'.
      Stravaig.FamilyTree.Blazor\Shared\Timeline\SubjectTimelineEntry.razor:5 Element 'scope' is obsolete or nonstandard
      Stravaig.FamilyTree.Blazor\Shared\Timeline\SubjectTimelineEntry.razor:6 Element 'scope' is obsolete or nonstandard
      Stravaig.FamilyTree.Blazor\Shared\Timeline\SubjectTimelineEntry.razor:7 Element 'scope' is obsolete or nonstandard
      Stravaig.FamilyTree.Blazor\Shared\Timeline\SubjectTimelineEntry.razor:8 Element 'scope' is obsolete or nonstandard
      Stravaig.FamilyTree.Blazor\Shared\Timeline\SubjectTimelineEntry.razor:9 Element 'scope' is obsolete or nonstandard
      Stravaig.FamilyTree.Blazor\Shared\Timeline\TimelineEntryNotes.razor:22 Type cast is redundant
      Stravaig.FamilyTree.Blazor\Shared\Timeline\TimelineEntrySources.razor:23 Type cast is redundant
    
    Project Stravaig.FamilyTree.Common
      Stravaig.FamilyTree.Common\Extensions\IEnumerableGedcomIndividualRecordExtensions.cs:7 Name 'IEnumerableGedcomIndividualRecordExtensions' does not match rule 'Types and namespaces'. Suggested name is 'EnumerableGedcomIndividualRecordExtensions'.
      Stravaig.FamilyTree.Common\Humaniser\EnglishLanguageRelationshipRenderer.cs:3 Namespace does not correspond to file location, should be: 'Stravaig.FamilyTree.Common.Humaniser'
      Stravaig.FamilyTree.Common\Humaniser\IRelationshipRenderer.cs:3 Namespace does not correspond to file location, should be: 'Stravaig.FamilyTree.Common.Humaniser'
    
    Project Stravaig.FamilyTree.Standardiser
      Stravaig.FamilyTree.Standardiser\Application.cs: Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Standardiser\Application.cs:2 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Standardiser\Application.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Standardiser\Application.cs:7 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Standardiser\CommandLineOptions.cs:33 Local variable 'absolutePath' is never used
      Stravaig.FamilyTree.Standardiser\FileNamer.cs:4 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTree.Standardiser\Program.cs:48 Type argument specification is redundant
      Stravaig.FamilyTree.Standardiser\Program.cs:49 Type argument specification is redundant
    
    Project Stravaig.FamilyTree.Standardiser.UnitTests
      Stravaig.FamilyTree.Standardiser.UnitTests\FileNamerTests.cs:3 Using directive is not required by the code and can be safely removed
    
    Project Stravaig.FamilyTreeGenerator
      Stravaig.FamilyTreeGenerator\Extensions\GedcomDateRecordFileNameExtensions.cs:2 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Extensions\StringExtensions.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Extensions\StringExtensions.cs:14 Name 'ellipsis' does not match rule 'Constant fields (private)'. Suggested name is 'Ellipsis'.
      Stravaig.FamilyTreeGenerator\Extensions\TextWriterExtensions.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Program.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Program.cs:12 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Program.cs:108 Type argument specification is redundant
      Stravaig.FamilyTreeGenerator\Program.cs:109 Type argument specification is redundant
      Stravaig.FamilyTreeGenerator\Requests\Handlers\ApplicationHandler.cs:18 Field '_options' is assigned but its value is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Glue\RenderMarriageIndexBaseHandler.cs:10 Namespace does not correspond to file location, should be: 'Stravaig.FamilyTreeGenerator.Requests.Handlers.Glue'
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Glue\RenderPersonAsJsonHandlerBase.cs:6 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Glue\RenderPersonAsJsonHandlerBase.cs:8 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Glue\RenderPersonAsJsonHandlerBase.cs:12 Namespace does not correspond to file location, should be: 'Stravaig.FamilyTreeGenerator.Requests.Handlers.Glue'
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Glue\RenderPersonIndexByMultipleLocationsBaseHandler.cs:12 Namespace does not correspond to file location, should be: 'Stravaig.FamilyTreeGenerator.Requests.Handlers.Glue'
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Glue\RenderPersonIndexBySingleLocationBaseHandler.cs:8 Namespace does not correspond to file location, should be: 'Stravaig.FamilyTreeGenerator.Requests.Handlers.Glue'
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderIndividualAsMarkdownHandler.cs:22 Field '_dateRenderer' is assigned but its value is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderMarriageByDateIndexHandler.cs:89 Type cast is redundant
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderMarriageByNameIndexHandler.cs:87 Type cast is redundant
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:4 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:16 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:17 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:18 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:19 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:20 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:21 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonAncestorsAsJsonHandler.cs:22 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:4 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:16 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:17 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:18 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:19 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:20 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:21 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonDescendantsAsJsonHandler.cs:22 Auto-property accessor is never used
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonFamilyTreeAsJsonHandler.cs:5 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonIndexBaseHandler.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonIndexBaseHandler.cs:6 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonIndexByDateOfBirthAsMarkdownHandler.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonIndexByDateOfBirthAsMarkdownHandler.cs:6 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonIndexByDateOfBirthAsMarkdownHandler.cs:8 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\RenderPersonIndexByNameAsMarkdownHandler.cs:5 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Services\IIndividualNameRenderer.cs: Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\Handlers\Services\TimelineMarkdownRenderer.cs: Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\RenderIndividual.cs:2 Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Requests\RenderPersonIndex.cs: Using directive is not required by the code and can be safely removed
      Stravaig.FamilyTreeGenerator\Services\FileNamer.cs: Using directive is not required by the code and can be safely removed
    
    Project Stravaig.Gedcom
      Stravaig.Gedcom\Extensions\CharExtensions.cs:163 Invalid tag header
      Stravaig.Gedcom\Extensions\StringExtensions.cs: Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Extensions\StringExtensions.cs:9 Constant 'Zero' is never used
      Stravaig.Gedcom\GedcomLine.cs: Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\GedcomLineReader.cs:12 Initializing field by default value is redundant
      Stravaig.Gedcom\GedcomPointer.cs:2 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\GedcomRecord.cs: Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\GedcomRecordReader.cs:9 Initializing field by default value is redundant
      Stravaig.Gedcom\Model\Comparers\DateComparer.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\EventRecord.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\Extensions\GedcomPlaceRecordExtensions.cs: Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\Extensions\GedcomSourceRecordExtensions.cs:2 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\Extensions\GedcomSourceRecordExtensions.cs:4 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\Extensions\IndividualTimelineExtensions.cs:48 Method 'GetBirthAndDeathOnly' is never used
      Stravaig.Gedcom\Model\Extensions\RelationshipExtensions.cs:2 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\Extensions\RelationshipExtensions.cs:4 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\GedcomIndividualRecord.cs:2 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\GedcomNoteRecord.cs:26 Field '_noteText' is assigned but its value is never used
      Stravaig.Gedcom\Model\GedcomSourceRecord.cs:3 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\GedcomSourceRecord.cs:5 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\GedcomSourceRecord.cs:6 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:130 Name 'SymbolAbout' does not match rule 'Constant fields (private)'. Suggested name is 'About'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:131 Name 'SymbolAboutAlt' does not match rule 'Constant fields (private)'. Suggested name is 'AboutAlt'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:132 Name 'SymbolAfter' does not match rule 'Constant fields (private)'. Suggested name is 'After'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:133 Name 'SymbolAfterAlt' does not match rule 'Constant fields (private)'. Suggested name is 'AfterAlt'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:134 Name 'SymbolAnd' does not match rule 'Constant fields (private)'. Suggested name is 'And'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:135 Name 'SymbolBefore' does not match rule 'Constant fields (private)'. Suggested name is 'Before'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:136 Name 'SymbolBeforeAlt' does not match rule 'Constant fields (private)'. Suggested name is 'BeforeAlt'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:137 Name 'SymbolBetween' does not match rule 'Constant fields (private)'. Suggested name is 'Between'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:138 Name 'SymbolBetweenAlt' does not match rule 'Constant fields (private)'. Suggested name is 'BetweenAlt'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:139 Name 'SymbolCalculated' does not match rule 'Constant fields (private)'. Suggested name is 'Calculated'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:140 Name 'SymbolEstimated' does not match rule 'Constant fields (private)'. Suggested name is 'Estimated'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:141 Name 'SymbolFrom' does not match rule 'Constant fields (private)'. Suggested name is 'From'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:142 Name 'SymbolInterpreted' does not match rule 'Constant fields (private)'. Suggested name is 'Interpreted'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:143 Name 'SymbolTo' does not match rule 'Constant fields (private)'. Suggested name is 'To'.
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:411 Redundant explicit delegate creation
      Stravaig.Gedcom\Model\Parsers\DateParser.cs:412 Redundant explicit delegate creation
      Stravaig.Gedcom\Model\Record.cs:4 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom\Model\Relationship.cs:7 Qualifier is redundant
      Stravaig.Gedcom\Model\TimelineEntry.cs:2 Using directive is not required by the code and can be safely removed
    
    Project Stravaig.Gedcom.PowerShell
      Stravaig.Gedcom.PowerShell\PSGedcomDatabase.cs:12 The field is always assigned before being used and can be converted to local variable
      Stravaig.Gedcom.PowerShell\PSGedcomDate.cs:6 Name 'PSGedcomDate' does not match rule 'Types and namespaces'. Suggested name is 'PsGedcomDate'.
    
    Project Stravaig.Gedcom.UnitTests
      Stravaig.Gedcom.UnitTests\Extensions\CharExtensions_Data.cs:5 Name 'CharExtensions_Data' does not match rule 'Types and namespaces'. Suggested name is 'CharExtensionsData'.
      Stravaig.Gedcom.UnitTests\Extensions\CharExtensions_IsGedcomAlphanumTests.cs:9 Name 'CharExtensions_IsGedcomAlphanumTests' does not match rule 'Types and namespaces'. Suggested name is 'CharExtensionsIsGedcomAlphanumTests'.
      Stravaig.Gedcom.UnitTests\Extensions\CharExtensions_IsGedcomAlphaTests.cs:9 Name 'CharExtensions_IsGedcomAlphaTests' does not match rule 'Types and namespaces'. Suggested name is 'CharExtensionsIsGedcomAlphaTests'.
      Stravaig.Gedcom.UnitTests\Extensions\CharExtensions_IsGedcomDigitTests.cs: Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom.UnitTests\Extensions\CharExtensions_IsGedcomOtherCharTests.cs:9 Name 'CharExtensions_IsGedcomNonAtTests' does not match rule 'Types and namespaces'. Suggested name is 'CharExtensionsIsGedcomNonAtTests'.
      Stravaig.Gedcom.UnitTests\Extensions\CharExtensions_IsGedcomOtherCharTests.cs:45 Name 'CharExtensions_IsGedcomOtherCharTests' does not match rule 'Types and namespaces'. Suggested name is 'CharExtensionsIsGedcomOtherCharTests'.
      Stravaig.Gedcom.UnitTests\Extensions\StringExtensions_AsGedcomSex.cs:9 Name 'StringExtensions_AsGedcomSex' does not match rule 'Types and namespaces'. Suggested name is 'StringExtensionsAsGedcomSex'.
      Stravaig.Gedcom.UnitTests\Extensions\StringExtensions_IsGedcomLevelTests.cs:10 Name 'StringExtensions_IsGedcomLevelTests' does not match rule 'Types and namespaces'. Suggested name is 'StringExtensionsIsGedcomLevelTests'.
      Stravaig.Gedcom.UnitTests\Extensions\StringExtensions_IsGedcomPointerTests.cs:8 Name 'StringExtensions_IsGedcomPointerTests' does not match rule 'Types and namespaces'. Suggested name is 'StringExtensionsIsGedcomPointerTests'.
      Stravaig.Gedcom.UnitTests\Extensions\StringExtensions_IsGedcomTagTests.cs:8 Name 'StringExtensions_IsGedcomTagTests' does not match rule 'Types and namespaces'. Suggested name is 'StringExtensionsIsGedcomTagTests'.
      Stravaig.Gedcom.UnitTests\Extensions\StringExtensions_SectionTests.cs:8 Name 'StringExtensions_SectionTests' does not match rule 'Types and namespaces'. Suggested name is 'StringExtensionsSectionTests'.
      Stravaig.Gedcom.UnitTests\GedcomLevelTests.cs:18 Local variable 'level' is never used
      Stravaig.Gedcom.UnitTests\GedcomLevelTests.cs:25 Local variable 'level' is never used
      Stravaig.Gedcom.UnitTests\GedcomLevelTests.cs:210 Redundant explicit array type specification
      Stravaig.Gedcom.UnitTests\GedcomLevelTests.cs:212 Redundant explicit array type specification
      Stravaig.Gedcom.UnitTests\GedcomLevelTests.cs:217 Redundant explicit array type specification
      Stravaig.Gedcom.UnitTests\GedcomLevelTests.cs:223 Redundant explicit array type specification
      Stravaig.Gedcom.UnitTests\GedcomLineParserTests.cs:4 Using directive is not required by the code and can be safely removed
      Stravaig.Gedcom.UnitTests\GedcomLineReaderTests.cs:19 Local variable 'gedcomReader' is never used
      Stravaig.Gedcom.UnitTests\GedcomLineReaderTests.cs:123 Local variable 'result' is never used
      Stravaig.Gedcom.UnitTests\Model\Comparers\DateComparerTests.cs:45 Local variable 'x' is never used
      Stravaig.Gedcom.UnitTests\Model\Comparers\DateComparerTests.cs:61 Local variable 'y' is never used
      Stravaig.Gedcom.UnitTests\Model\Extensions\RelationshipExtensionsTests.cs:23 Local variable 'alice' is never used
@colinangusmackay
Copy link
Member Author

Closed by PR #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant