Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{appservice-kube} Ensure compatibility with upcoming CLI version #1

Closed
wants to merge 1 commit into from

Conversation

StrawnSC
Copy link
Owner

@StrawnSC StrawnSC commented Feb 2, 2022

The upcoming CLI version will have this feature: Azure/azure-cli#21057, which slightly changes some interfaces that were used in the az webapp create implementation here. This PR ensures that the az webapp create command will remain functional with upcoming CLI version 2.33.0


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@StrawnSC StrawnSC closed this Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant