Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, we install unzipper unconditionally, even though it's only required by the window, which causes a lot of unnecessary installs to
node_modules/beamcoder/node_modules
. Additionally, we also depend on it, which causes those same dependencies to also be added to my project, but i think not actually made available to the beamcoder install process if it needs them. This leads to a significant increase in disk usage by programs using beamcoder.To fix this, we only actually install unzipper inside the windows installer, and only load it near the call site.
FWIW, a better direction for the future might be to factor
install_ffmpeg.js
out into a separate package. You could make it a peer dependency, or just catch ffmpeg-not-found type errors and print "try installingbeamcoder-install-ffmpeg
".