Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only install unzipper on windows #14

Closed

Conversation

dradetsky
Copy link

currently, we install unzipper unconditionally, even though it's only required by the window, which causes a lot of unnecessary installs to node_modules/beamcoder/node_modules. Additionally, we also depend on it, which causes those same dependencies to also be added to my project, but i think not actually made available to the beamcoder install process if it needs them. This leads to a significant increase in disk usage by programs using beamcoder.

To fix this, we only actually install unzipper inside the windows installer, and only load it near the call site.

FWIW, a better direction for the future might be to factor install_ffmpeg.js out into a separate package. You could make it a peer dependency, or just catch ffmpeg-not-found type errors and print "try installing beamcoder-install-ffmpeg".

@scriptorian
Copy link
Contributor

Thanks for this. I have updated the head revision so will now close this pull request.

@scriptorian scriptorian closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants