Skip to content

Commit

Permalink
Add Avrora.Utils.Registrar module (#63)
Browse files Browse the repository at this point in the history
* Add Avrora.Utils.Registrar module
* Make Avrora.Storage.File.get/1 docs visible and fix ASCII example
  • Loading branch information
Strech committed Jan 19, 2021
1 parent 1b4bf31 commit d8c7abb
Show file tree
Hide file tree
Showing 4 changed files with 499 additions and 16 deletions.
21 changes: 9 additions & 12 deletions lib/avrora/storage/file.ex
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ defmodule Avrora.Storage.File do
Files are stored with each namespace component as a folder name.
For example `io.confluent.Payment` should be stored as follows:
.
├── lib/
├── priv/
│ ├── ...
│ └── schemas/
│ └── io/
│ └── confluent/
│ └── Payment.avsc
└── ...
.
├── lib/
├── priv/
│ ├── ...
│ └── schemas/
│ └── io/
│ └── confluent/
│ └── Payment.avsc
└── ...
## Examples
Expand All @@ -40,10 +40,7 @@ defmodule Avrora.Storage.File do
do: Schema.parse(body, &read_schema_file_by_name/1)
end

@doc false
def get(key) when is_integer(key), do: {:error, :unsupported}

@doc false
def put(_key, _value), do: {:error, :unsupported}

defp read_schema_file_by_name(name) do
Expand Down
7 changes: 3 additions & 4 deletions lib/avrora/storage/registry.ex
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ defmodule Avrora.Storage.Registry do
## Examples
iex> schema = ~s({"fields":[{"name":"id","type":"string"},{"name":"amount","type":"double"}],"name":"Payment","namespace":"io.confluent","type":"record"})
iex> {:ok, schema} = Avrora.Storage.Registry.put("io.confluent.examples.Payment", schema)
iex> schema.full_name
...> schema = ~s({"fields":[{"name":"id","type":"string"},{"name":"amount","type":"double"}],"name":"Payment","namespace":"io.confluent","type":"record"})
...> {:ok, schema} = Avrora.Storage.Registry.put("io.confluent.examples.Payment", schema)
...> schema.full_name
"io.confluent.Payment"
"""
def put(key, value) when is_binary(key) and is_binary(value) do
Expand All @@ -88,7 +88,6 @@ defmodule Avrora.Storage.Registry do
end
end

@doc false
def put(_key, _value), do: {:error, :unsupported}

@doc false
Expand Down
114 changes: 114 additions & 0 deletions lib/avrora/utils/registrar.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
defmodule Avrora.Utils.Registrar do
@moduledoc """
Memory store-aware schema registration with extended functionality
designed to be used in the intensive loops.
It gives you control over the name under which schema will be registered
(i.e subject in Schema Registry) and allows you to enforce registration
even if the schema exists.
## Examples
defmodule Sample do
alias Avrora.Utils.Registrar
def loop do
Enum.reduce_while(1..100, 0, fn x, acc ->
if x < 100, do: {:cont, register("io.confluent.Payment")}, else: {:halt, acc}
end)
end
defp register(schema_name), do: Registrar.register_schema_by_name(schema_name)
end
"""

require Logger
alias Avrora.{Config, Schema}

@doc """
Register schema from local schema file in the Schema Registry.
Schema name conventions inherited from `Avrora.Storage.File.get/1`.
For extended documentation about registration process see `register_schema/2`.
## Options
* `:as` - the name which will be used to register schema (i.e subject).
* `:force` - the flag enforcing registration when schema was found
in the Memory store (`false` by default).
## Examples
...> {:ok, schema} = Avrora.Utils.Registrar.register_schema_by_name("io.confluent.Payment", as: "NewName", force: true)
...> schema.full_name
"io.confluent.Payment"
"""
@spec register_schema_by_name(String.t(), as: String.t(), force: boolean) ::
{:ok, Schema.t()} | {:error, term()}
def register_schema_by_name(name, opts \\ []) do
if Keyword.get(opts, :force, false) do
with {:ok, schema} <- file_storage().get(name), do: register_schema(schema, opts)
else
with {:ok, nil} <- memory_storage().get(name),
{:ok, schema} <- file_storage().get(name) do
register_schema(schema, Keyword.put(opts, :force, true))
end
end
end

@doc """
Register schema in the Schema Registry.
This function relies on a Memory store before taking action.
The most complete schema name will be looked at the store, i.e if the schema
contains `version` then `full_name` + `version` will be used in prior just a `full_name`.
## Options
* `:as` - the name which will be used to register schema (i.e subject).
* `:force` - the flag enforcing registration when schema was found
in the Memory store (`false` by default).
## Examples
...> {:ok, schema} = Avrora.Resolver.resolve("io.confluent.Payment")
...> {:ok, schema} = Avrora.Utils.Registrar.register_schema(schema, as: "NewName", force: true)
...> schema.full_name
"io.confluent.Payment"
"""
@spec register_schema(Schema.t(), as: String.t(), force: boolean) ::
{:ok, Schema.t()} | {:error, term()}
def register_schema(schema, opts \\ []) do
full_name =
if is_nil(schema.version),
do: schema.full_name,
else: "#{schema.full_name}:#{schema.version}"

subject = Keyword.get(opts, :as, full_name)

if Keyword.get(opts, :force, false) do
do_register(subject, schema)
else
with {:ok, nil} <- memory_storage().get(full_name), do: do_register(subject, schema)
end
end

defp do_register(subject, schema) do
with {:ok, schema} <- registry_storage().put(subject, schema.json),
{:ok, schema} <- memory_storage().put(schema.id, schema),
{:ok, schema} <- memory_storage().put(schema.full_name, schema),
{:ok, timestamp} <- memory_storage().expire(schema.full_name, names_ttl()) do
if timestamp == :infinity,
do: Logger.debug("schema `#{schema.full_name}` will be always resolved from memory")

if is_nil(schema.version),
do: {:ok, schema},
else: memory_storage().put("#{schema.full_name}:#{schema.version}", schema)
end
end

defp file_storage, do: Config.self().file_storage()
defp memory_storage, do: Config.self().memory_storage()
defp registry_storage, do: Config.self().registry_storage()
defp names_ttl, do: Config.self().names_cache_ttl()
end

0 comments on commit d8c7abb

Please sign in to comment.