This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Don't print long apt keys to the log #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly for the 200-line Tor key, but the other (25-line) keys were hidden for consistency.
jlund
suggested changes
Jul 29, 2018
| @@ -1,4 +1,4 @@ | |||
| - name: Add the APT key for acmetool | |||
| - name: "Add the APT key for acmetool; hiding 25 lines of log..." | |||
| apt_key: | |||
| id: 9862409EF124EC763B84972FF5AC9651EDB58DFA | |||
| data: "{{ item }}" | |||
There was a problem hiding this comment.
Fixed.
What happened here was that I did a more extensive purge of with_file, given that with_foo loops have been deprecated in general. But on closer reading, with_file hasn't been deprecated, probably because it's cleaner-looking than:
- name: "Add the evil repository"
apt_key:
id: C0DEDBAD
data: "{{ lookup('file', 'files/signing-key') }}"So I backed off all of those patches, and went too far. Oops.
| @@ -5,7 +5,7 @@ | |||
| state: absent | |||
| with_items: "{{ apache_packages_to_remove }}" | |||
|
|
|||
| - name: Add the official Nginx APT key | |||
| - name: "Add the official Nginx APT key; hiding 25 lines of log..." | |||
| apt_key: | |||
| id: 7BD9BF62 | |||
| data: "{{ item }}" | |||
xiangwyao
added a commit
to xiangwyao/streisand
that referenced
this pull request
Aug 12, 2018
* Make sure both gpg-agent and dirmngr have picked up new configuration (StreisandEffect#1387) @hamidzr wrote StreisandEffect#1335, which fixes StreisandEffect#1333, a case of a running `gpg-agent` not picking up changes from GPG configuration. When testing, I noticed the configuration issue affects `dirmngr` as well. If there's a running `dirmngr`, provisioning fails when trying to update the keyring. This patch addresses both components. `dirmngr` doesn't seem respond to HUP or `--reload`, so it needs to be killed and restarted. Resolves StreisandEffect#1333. * - mobileconfig re-generated from apple configurator 2 (StreisandEffect#1398) - .mobileconfig re-generated from Apple Configurator 2 (DeviceUniqueIdentifier key/value from VedorConfig and ProviderType packet-tunnel setting now removed) - uppercase UUIDs * Remove "ec2:DescribeAlarms" from suggested IAM policy (StreisandEffect#1407) "ec2:DescribeAlarms" doesn't exist. * Updated Documentation for Ubuntu 16.04, 17.10, and 18.04 (StreisandEffect#1408) There have been some issues with versions of Ubuntu. See Issue StreisandEffect#1296 for information about problems with 16.04. 16.10 and 17.04 are now end of life (see https://wiki.ubuntu.com/Releases). I have updated the documentation (minor changes) to reflect 16.04, 17.10, and 18.04, which are currently supported. * Ensure VPN profile names fit in Linux network device names (StreisandEffect#1400) There's a 15-character limit on the length of Linux network device names, and it would be nice to use the VPN profile names as interface names. A few of the wordlist words are 8 letters long. We can use two words as long as they're each 7 characters or shorter (leaving room for the separator). * When checking syntax, don't search inside the venv directory (StreisandEffect#1395) Now that we're telling people to use ./venv as a place to put virtualenvs, don't search there when we're checking syntax. * Don't print long apt keys to the log (StreisandEffect#1412) This is mostly for the 200-line Tor key, but the other (25-line) keys were hidden for consistency. * Add WireGuard instructions for Android using the new QR code support. (StreisandEffect#1413) * WireGuard instructions update (StreisandEffect#1417) * Add WireGuard instructions for Android using the new QR code support. * update wireguard fr instructions * Update readme-fr (StreisandEffect#1419) * Update OpenVPN instuctions (StreisandEffect#1420) - update fr instructions to reflect changes made in StreisandEffect#1408 - correct instructions to mention LZ4 compression instead of LZO * Fix stunnel windows mirror download location (StreisandEffect#1425)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for the 200-line Tor key, but the other (25-line) keys were hidden for consistency.