Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Parameters were omitted from subtitle requests on new clients #221

Open
maormagori opened this issue Jun 10, 2023 · 1 comment
Open

Comments

@maormagori
Copy link

maormagori commented Jun 10, 2023

Hello,
I'm the maintainer of two subtitles addons and recently noticed a difference in the way the new clients make requests to my addons.
It appears that "Extra Parameters" are not a part of the requests' URL path anymore.
For example, here's the URL to watch the same media. One made by the Windows client, the other by the new web client:

'/subtitles/movie/tt10366206/videoHash=9d8c1e6c3d434f50&videoSize=1632335363&filename=John.Wick.Chapter.4.2023.720p.WEBRip.x264.AAC-%5BYTS.MX%5D.mp4.json'
'/subtitles/movie/tt10366206.json'

Windows client version - 4.4.160
Web App version - 5.0.0
Stremio server version for both - 4.20.0

Looking back at the logs, this started with the new Android TV client.

Both of my addons rely on the filename argument to sort the subtitles by most relevant to least. The new behavior disables this much-needed feature.

Is it possible to add it back?
If it was intentional, I think it's worth updating the docs (here and here) and maybe let us know if there were more changes to the way Stremio makes requests.

Thanks!

@jaruba
Copy link
Member

jaruba commented Jun 10, 2023

This is the related PR from Stremio Web: Stremio/stremio-web#365

This is happening because Stremio Web and Stremio Android TV both use the new stremio-core: https://github.com/Stremio/stremio-core

All Stremio projects will use the core in the future, but it currently does have some features missing compared to the old methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants