Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon catalogs + manifest.behaviorHints #97

Merged
merged 16 commits into from
Sep 6, 2019
Merged

Addon catalogs + manifest.behaviorHints #97

merged 16 commits into from
Sep 6, 2019

Conversation

Ivshti
Copy link
Member

@Ivshti Ivshti commented Sep 2, 2019

Implements an ability for addons to provide catalogs with addons, therefore adding the addon repository feature to Stremio

See #28

This option seems least cumbersome to implement: "alternatively, addon catalogs will be hidden behind a required property, and we will instantiate CatalogFiltered with some extra prop already passed;"

Others have problems: .addon_catalogs requires another generic trait, makes things much more complicated, for essentially what is the same data structure as .catalogs; as for resource_name, it's weird cause .catalogs implies a catalog resource

Checklist:

  • items_group should use CatalogError
  • consider using items_group for CatalogFiltered or alternatively use try_from directly, to make it polymorphic
  • preview Descriptor or generic Descriptor
  • implement CatalogAdapter and manifest.addon_catalogs

@Ivshti Ivshti marked this pull request as ready for review September 6, 2019 19:29
@Ivshti Ivshti changed the title Addon catalogs Addon catalogs + manifest.behaviorHints Sep 6, 2019
@Ivshti Ivshti merged commit a08a497 into master Sep 6, 2019
@Ivshti Ivshti deleted the addon-catalogs branch September 13, 2019 13:11
@Ivshti Ivshti mentioned this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant