Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Using External Players in Settings and Player #375

Merged
merged 31 commits into from
May 31, 2023
Merged

Allow Using External Players in Settings and Player #375

merged 31 commits into from
May 31, 2023

Conversation

jaruba
Copy link
Member

@jaruba jaruba commented May 29, 2023

Untested, awaiting stremio-core changes, based on the discussion had today with @unclekingpin and @elpiel

jaruba added 20 commits May 29, 2023 17:38
@jaruba
Use Bowser to Detect Mobile
c934788
@jaruba
Improve isMobile API
4f82b85
@jaruba
Rename isMobile.js to platform.js
bec44f5
@jaruba
Rename isMobile.js to platform.js 2
bfb2661
@jaruba
Support Downloading M3U Playlist If Local Server Offline and Not Mobile
15fed24
@jaruba
Move All Necessary Logic to Stream.js
b7ed499
@jaruba
Use deepLinks.externalPlayer.fileName for M3U Playlist Name
b74a0a3
@jaruba
Don't Use a href Anymore When Handling External Player Open With Lo…
2c7d925 
…cal Server
@jaruba
Ensure haveStreamingServer Availability is Satisfied
68bba90
@jaruba
Ensure haveStreamingServer Availability is Satisfied 2
22aa3a5
@jaruba
Add Toast When Opening In External Player
8337fd6
@jaruba
Lint
4e2d8bf
@jaruba
Add Select Options for External Players
d709f2c
@jaruba
Lint
68b31f9
@jaruba
Lint
dbe48c3
@jaruba
Add .openPlayer for New Core Changes
5b8c211
@jaruba
Add Prop Type for openPlayer
b20359f
@jaruba
Add Prop Types for openPlayer 2
68bee7f
@jaruba
Bump stremio-translations
f2e119f
@jaruba
Bump stremio-core-web
1064513
@jaruba jaruba mentioned this pull request May 31, 2023
Closed
@jaruba jaruba changed the title Allow Using VLC as External Player on iOS and Android Allow Using External Players May 31, 2023
jaruba added a commit that referenced this pull request May 31, 2023
@jaruba
Add Install Link to Server Warning
81d4339 
This needs translations updated from: #375
@jaruba jaruba mentioned this pull request May 31, 2023
Merged
@jaruba
Copy link
Member Author

jaruba commented May 31, 2023 •
edited
Loading

Tested on:

[MacOS] Disabled, VLC (with and without server attached, all is working as expected)
[iPad] Disabled, VLC, Outplayer, Infuse (Infuse is the only one that is acting wonky and refuses to play some streams, but works with others, we may consider disabling support for it)
[Android] Disabled, Allow Choosing, VLC, Just Player, MX Player (all are working as expected)

@elpiel elpiel changed the title Allow Using External Players Allow Using External Players in Settings May 31, 2023
@elpiel elpiel changed the title Allow Using External Players in Settings Allow Using External Players in Settings and Player May 31, 2023
@elpiel
Copy link
Member

elpiel commented May 31, 2023

LGTM!

@TRtomasz TRtomasz self-requested a review May 31, 2023 09:59
@elpiel
Copy link
Member

elpiel commented May 31, 2023 •
edited
Loading

Stremio-web settings were tested:

  • Andoird (firefox) Has options: Allow choosing, VLC Just player MX Player, tested with: Allow choosing, VLC
  • Ubuntu 20.04 (firefox), has options: VLC , tested with: VLC

With both cases covered:

  • With a running server.js
  • Without a running server.js

TRtomasz
TRtomasz approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@TRtomasz TRtomasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android
and Windows
Works fine, except one thing that has been opened #378 but not a biggy so can be done after initial release

@jaruba jaruba merged commit 49cf961 into development May 31, 2023
1 check passed
@elpiel elpiel deleted the external-players branch May 31, 2023 10:17
@elpiel elpiel mentioned this pull request Jun 21, 2023
Open
@tymmesyde tymmesyde mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleeyax sleeyax sleeyax left review comments

@elpiel elpiel elpiel approved these changes

@TRtomasz TRtomasz TRtomasz approved these changes

@nklhtv nklhtv Awaiting requested review from nklhtv

@tymmesyde tymmesyde Awaiting requested review from tymmesyde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaruba @elpiel @sleeyax @TRtomasz