Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Player): change volume with mouse wheel #405

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

tymmesyde
Copy link
Member

No description provided.

Comment on lines +588 to +598
const onWheel = ({ deltaY }) => {
if (deltaY > 0) {
if (!subtitlesMenuOpen && !infoMenuOpen && !videosMenuOpen && !speedMenuOpen && !optionsMenuOpen && !statisticsMenuOpen && videoState.volume !== null) {
onVolumeChangeRequested(videoState.volume - 5);
}
} else {
if (!subtitlesMenuOpen && !infoMenuOpen && !videosMenuOpen && !speedMenuOpen && !optionsMenuOpen && !statisticsMenuOpen && videoState.volume !== null) {
onVolumeChangeRequested(videoState.volume + 5);
}
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to:

Suggested change
const onWheel = ({ deltaY }) => {
if (deltaY > 0) {
if (!subtitlesMenuOpen && !infoMenuOpen && !videosMenuOpen && !speedMenuOpen && !optionsMenuOpen && !statisticsMenuOpen && videoState.volume !== null) {
onVolumeChangeRequested(videoState.volume - 5);
}
} else {
if (!subtitlesMenuOpen && !infoMenuOpen && !videosMenuOpen && !speedMenuOpen && !optionsMenuOpen && !statisticsMenuOpen && videoState.volume !== null) {
onVolumeChangeRequested(videoState.volume + 5);
}
}
};
const onWheel = ({ deltaY }) => {
if (!subtitlesMenuOpen && !infoMenuOpen && !videosMenuOpen && !speedMenuOpen && !optionsMenuOpen && !statisticsMenuOpen && videoState.volume !== null) {
onVolumeChangeRequested(deltaY > 0 ? videoState.volume - 5 : videoState.volume + 5);
}
};

Or even shorter:

      // ...
      onVolumeChangeRequested(videoState.volume + (deltaY > 0 ? -5 : 5));

Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how on most players the wheel can work when you've hovered on the volume control itself but I guess if you add some visual cue that you are changing your volume this is also good.

@tymmesyde
Copy link
Member Author

tymmesyde commented Jun 22, 2023

I like how on most players the wheel can work when you've hovered on the volume control itself but I guess if you add some visual cue that you are changing your volume this is also good.

A visual indicator could be a nice thing to add
See this #425

@tymmesyde tymmesyde merged commit cf184ab into development Jul 11, 2023
1 check passed
@elpiel elpiel deleted the feat/player-volume-mouse-wheel branch July 25, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants