Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github ref_name for all branches #427

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

unclekingpin
Copy link
Contributor

With the current implementation all of the branches that are deployed to gh pages are gone, once a PR is merged into development

@TRtomasz
Copy link
Member

i see i'm assigned but this is more devops change not a functional/feature change in the app
based on the description i have no idea what this could affect, do we even have automatic github pages deployments?

@unclekingpin
Copy link
Contributor Author

@TRtomasz yes we have, sorry for the tag

@unclekingpin unclekingpin removed the request for review from TRtomasz July 19, 2023 15:01
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elpiel
Copy link
Member

elpiel commented Jul 19, 2023

Redirecting to development deployment

Otherwise, when you go to https://stremio.github.io/stremio-web/ it will be a blank page.

@jaruba jaruba merged commit ba25c47 into development Jul 19, 2023
2 checks passed
@elpiel elpiel deleted the build-workflow-fix branch July 19, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants