Upgraded ICS to 4.0 #1153
Merged
Upgraded ICS to 4.0 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
C:CLI
C:stakeibc
C:test
dependencies
asalzmann
approved these changes
Mar 21, 2024
|
|
||
| // Migrates ICS Params to add the new RetryDelayParam | ||
| func MigrateICSParams(ctx sdk.Context, ck ccvconsumerkeeper.Keeper) { | ||
| params := ck.GetConsumerParams(ctx) |
There was a problem hiding this comment.
Nice - so this didn't work pre-SDK 47, and now it does?
There was a problem hiding this comment.
that's my guess. Although, I think it might be up to the specific module. For instance, Stride as a chain is on SDK 47 but I don't think stakeibc ever upgraded the param store to the new format (low confidence though)
Either way, we can figure out if this works right away through the dockernet IG tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgraded ICS to v4
Brief Changelog