Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Someone hit the webhook for 'xxx' and it failed to validate. #10

Closed
chevett opened this issue Mar 17, 2014 · 10 comments
Closed

Someone hit the webhook for 'xxx' and it failed to validate. #10

chevett opened this issue Mar 17, 2014 · 10 comments

Comments

@chevett
Copy link

chevett commented Mar 17, 2014

Strider was really easy to get mostly working! The only issue I'm having is that web hooks from github aren't validating and therefore aren't triggering builds.

I have a server running strider on http://localhost:3000 then I have nginx in front of that handling the ssl at https://ci.miketown3.com.

I'm trying to get notifications from https://github.com/rrrelay/named-logger and it's setup to hit https://ci.miketown3.com/rrrelay/named-logger/api/github/webhook.

In the strider logs, I see

 warn: Someone hit the webhook for rrrelay/named-logger and it failed to validate
POST /rrrelay/named-logger/api/github/webhook 401 55ms - 17b

I've been testing the webhook from the github page and it looks like this...
2014-03-16_2059

I've also created a new github application and set the env variables PLUGIN_GITHUB_APP_ID and PLUGIN_GITHUB_SECRET to the client id and client secret.

Is the payload missing the x-hub-signature header or something? Any help/ideas would be greatly appreciated! Thanks!

@freewil
Copy link
Contributor

freewil commented Apr 4, 2014

What is the response? Does it say 'Invalid Signature'. See #8

@chevett
Copy link
Author

chevett commented Apr 5, 2014

Oh super! Thanks a bunch.

@chevett chevett closed this as completed Apr 5, 2014
@chevett
Copy link
Author

chevett commented Apr 5, 2014

ooops, nevermind. It is still not working for me. I took #8 to mean if I deleted and recreated the hooks through the github ui then it would all work. I did that and I'm still getting the 401 Invalid Signature.

@chevett chevett reopened this Apr 5, 2014
@chevett
Copy link
Author

chevett commented Apr 5, 2014

ok, the github UI does not work for me. I got it to work by deleting, recreating and then manually setting the config.insecure_ssl to 1 through the github api.

I can't deal with manually doing this for each project, so I hard coded the setting: chevett@6e7861a

I was looking for a place in the UI to add a checkbox for this setting, but I couldn't find a place for a global level setting like this. If you guys can point me in the right direction I'd be happy to add this to the UI.

@jaredly
Copy link
Member

jaredly commented Apr 5, 2014

Are you using strider HEAD? Or the npm version?

On 4/5/14, Mike Chevett notifications@github.com wrote:

ok, the github UI does not work for me. I got it to work by deleting,
recreating and then manually setting the config.insecure_ssl to 1 through
the github api.

I can't deal with manually doing this for each project, so I hard coded the
setting:
chevett@6e7861a

I was looking for a place in the UI to add a checkbox for this setting, but
I couldn't find a place for a global level setting like this. If you guys
can point me in the right direction I'd be happy to add this to the UI.


Reply to this email directly or view it on GitHub:
#10 (comment)

@chevett
Copy link
Author

chevett commented Apr 5, 2014

I was using the npm version, but now I'm on HEAD. Or really, one commit ahead of HEAD: chevett/strider@6ec657a

I tested the hooks with npm version and couldn't get it to work. So, I forked and added the hard coded insecure_ssl field.

@knownasilya
Copy link
Member

@chevett I'm assuming this is still an issue even with the current master version?

@chevett
Copy link
Author

chevett commented Jan 15, 2015

I haven't updated in a while, but I can give it a try this afternoon if
that's helpful.
On Jan 15, 2015 10:28 AM, "Ilya Radchenko" notifications@github.com wrote:

@chevett https://github.com/chevett I'm assuming this is still an issue
even with the current master version?


Reply to this email directly or view it on GitHub
#10 (comment)
.

@knownasilya
Copy link
Member

@chevett would be much appreciated! 👍

@chevett
Copy link
Author

chevett commented Jan 15, 2015

There isn't much of an issue here anymore. There was a bug in the github ui that messed up the webhook if you disabled the ssl verification and I have just confirmed that this bug has been fixed by github.

If you have a strider instance that is using a self signed cert, then you have manually disable ssl verification through the github webhook ui and that is working correctly now.

@chevett chevett closed this as completed Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants