Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"build time" includes time waiting in a queue #133

Closed
jaredly opened this issue Jul 21, 2013 · 6 comments
Closed

"build time" includes time waiting in a queue #133

jaredly opened this issue Jul 21, 2013 · 6 comments

Comments

@jaredly
Copy link
Member

jaredly commented Jul 21, 2013

It seems there ought to be a duration field stored in the database. Because finished-created doesn't quite capture it.

@niallo
Copy link
Member

niallo commented Jul 22, 2013

we could add another field like "start_timestamp" which is set to the moment the simple-worker actually begins processing. thoughts?

on a related note, the "-1" duration on the job dashboard should be fixable with client-side code?

@jaredly
Copy link
Member Author

jaredly commented Jul 22, 2013

yeah I like the idea of a "start_timestamp".
Yeah, that will eventually have the same running counter you see on the
build page.

On Sun, Jul 21, 2013 at 11:44 PM, niallo notifications@github.com wrote:

we could add another field like "start_timestamp" which is set to the
moment the simple-worker actually begins processing. thoughts?

on a related note, the "-1" duration on the job dashboard should be
fixable with client-side code?


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-21325687
.

@niallo
Copy link
Member

niallo commented Jul 22, 2013

for start_timestamp, we just need to add an additional property on "update_status" events. when this is included, Strider can save it to the job document.

@jaredly
Copy link
Member Author

jaredly commented Jul 22, 2013

yup. sounds great.

On Sun, Jul 21, 2013 at 11:47 PM, niallo notifications@github.com wrote:

for start_timestamp, we just need to add an additional property on
"update_status" events. when this is included, Strider can save it to the
job document.


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-21325742
.

@jaredly
Copy link
Member Author

jaredly commented Jul 22, 2013

I'd also like to separate out "deploy time". Because deploying to heroku
can add on another 5-10 minutes to the overall build time ... and I don't
know that I'm as much interested in that as in the time it takes to build &
run tests.

On Sun, Jul 21, 2013 at 11:48 PM, Jared Forsyth jabapyth@gmail.com wrote:

yup. sounds great.

On Sun, Jul 21, 2013 at 11:47 PM, niallo notifications@github.com wrote:

for start_timestamp, we just need to add an additional property on
"update_status" events. when this is included, Strider can save it to the
job document.


Reply to this email directly or view it on GitHubhttps://github.com//issues/133#issuecomment-21325742
.

@niallo
Copy link
Member

niallo commented Oct 19, 2013

Looks like this is done in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants