Use hubot style app deployment #18
Conversation
|
I think the idea is a good one. Thanks for making the pull request. Some of the details in the diff I don't follow (for example the config.js changes which seem to duplicate what everypaas already does) and I don't think I can accept the package.json changes. That being said I like the idea of being able to depend on strider and version it. |
|
Could you comment on the particular lines and we can talk through it :) |
|
Ok. I've got some work to do 😄 I'm glad you like it though. I'll start on it tomorrow and push my changes when I'm done. Thanks for your work on strider! |
|
Awesome. Thanks for hacking on this. BTW you might be interested in this: https://github.com/niallo/deadlift Right now it is customized for Strider, but I have been meaning to make it more generic in future. |
|
I actually tried it a couple of weeks ago and didn't work for me. If I remember correctly I think it just got stuck on one of the steps and so I just did my own deployment. But I really like the idea and I'm sure there's been changes made since then. |
|
In terms of the config stuff, I'm attacking that in the removeConfig branch |
|
@peterbraden awesome! I was going to work on this stuff this weekend. Sorry it's taking so long :( |
|
This has been solved by merging @peterbraden's removeConfig branch and by #30. See sample usage in README.md. |
|
@niallo you're awesome! thanks for taking care of this :) |
This allows you to setup a project to depend on strider instead of cloning the strider repo and maintain the upstream changes that occur. A strider instance would use a setup similar to this template and that is what gets deployed to heroku. That way, I can version my dependency on strider and get any updates that occur just by changing my
package.json. This is very similar to the way github's hubot works.