Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose values with getattr #572

Merged
merged 14 commits into from
May 13, 2024
Merged

expose values with getattr #572

merged 14 commits into from
May 13, 2024

Conversation

ekorman
Copy link
Contributor

@ekorman ekorman commented Apr 30, 2024

this PR does the following to address #571:

  • for attributes of a StaticCollection that are simple types (e.g. String, Integer, etc), have __getattribute__ return the value
  • update __repr__ to be explicit that these objects are not standard types. this is something that made me confused when i was using valor because it made me think that certain objects such as String, Integer were built-in types

@ntlind ntlind mentioned this pull request May 1, 2024
@ntlind
Copy link
Collaborator

ntlind commented May 6, 2024

#571

client/valor/coretypes.py Show resolved Hide resolved
client/valor/schemas/symbolic/collections.py Outdated Show resolved Hide resolved
client/valor/schemas/symbolic/collections.py Outdated Show resolved Hide resolved
@ekorman ekorman merged commit 1c10888 into main May 13, 2024
11 checks passed
@ekorman ekorman deleted the get-value-from-vars branch May 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants