-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text comparison metrics to Ben's PR #632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnativi
reviewed
Jun 21, 2024
api/tests/functional-tests/backend/metrics/test_text_generation.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
evaluate_text_generation
python-slim
frompython-alpine
since the latter doesn't seem to work with hugging face's dependencies (e.g.,pyarrow
). Rationale is listed below. Alternatively, we can try to stick with alpine and try manually installingpyarrow
's dependencies.python3.10-alpine
; first it wasscipy
, now it'spyarrow
. Switching back means shorter build times and fewer dependency limitationsalpine
because John said that "ubuntu/debian has historically been pretty bad at patching security issues.". This doesn't seem like an overriding concern, and one that matters less in a future world where we're decoupling from Chariot.python3.10-slim
is a "Docker Official" image; it seems secure enough for our use.