New features and fixes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiddenCommands can be disabled from execution or displaying with "help" command Moved/Replaced logic for CommandExecutor#print to Console#printCommands
HiddenCommand allows Commands to be hidden from help and command completer.
| @@ -115,6 +115,8 @@ public void setCommandExecutor (CommandExecutor commandExec) { | |||
| */ | |||
| @Override | |||
| public void execCommand(String command) { | |||
| if(disabled) return; | |||
There was a problem hiding this comment.
just curious, does this fix some usecase?
There was a problem hiding this comment.
This enforces the disabled flag, whether it is a GUIConsole, HeadlessConsole, or even a custom Console extended from AbstractConsole, it is disabled from executing commands.
|
Thanks again man, this is some good work you're doing |
|
No problem. I appreciate your acceptance of my code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented HiddenCommand annotation for CommandExecutor methods
Moved logic for CommandExecutor.print() to Console.printCommands()
Fixed console not being disabled while not using GUIConsole if disabled flag was set
Refactored and updated method and argument determination/parsing code
Updated Box2DTest with HiddenCommand methods
Added ConsoleTest