Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience api #4

Merged
merged 5 commits into from
Feb 13, 2015
Merged

Convenience api #4

merged 5 commits into from
Feb 13, 2015

Conversation

piotr-j
Copy link
Contributor

@piotr-j piotr-j commented Feb 13, 2015

Added new api to clear the console and set maximum number of entries allowed.

Refactored refresh() to not create new labels every time.

@StrongJoshua
Copy link
Owner

Smart move with improving the refresh function. I think I'll add an option to have unlimited entries.

StrongJoshua added a commit that referenced this pull request Feb 13, 2015
@StrongJoshua StrongJoshua merged commit 13315ca into StrongJoshua:master Feb 13, 2015
@piotr-j
Copy link
Contributor Author

piotr-j commented Feb 13, 2015

Cool, i think ill implement custom position next. I dont like the
halfscreen stuff
On 13 Feb 2015 20:34, "StrongJoshua" notifications@github.com wrote:

Merged #4 #4.


Reply to this email directly or view it on GitHub
#4 (comment)
.

@StrongJoshua
Copy link
Owner

Sure :) I was thinking of allowing the console to be movable and resizable (with constraints of course).

@StrongJoshua
Copy link
Owner

haha, I think we use different formatters, so merging often has many white-space changes :P

@piotr-j
Copy link
Contributor Author

piotr-j commented Feb 14, 2015

Yeah, Ill try to clean this up better next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants