-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade #54
base: master
Are you sure you want to change the base?
Upgrade #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about a change you made to the deployment portion of the build.gradle file.
@@ -71,11 +71,11 @@ uploadArchives { | |||
beforeDeployment { MavenDeployment deployment -> signing.signPom(deployment) } | |||
|
|||
repository(url: "https://oss.sonatype.org/service/local/staging/deploy/maven2/") { | |||
authentication(userName: ossrhUsername, password: ossrhPassword) | |||
authentication(userName: hasProperty('ossrhUsername')?ossrhUsername:'', password: hasProperty('ossrhPassword')?ossrhPassword:'') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if no username/password are passed through the authentication? Won't it just fail? If so, why do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please separate each upgrade as one pull request. That's the correct way of doing that. Thanks.
replaces #53