Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot4 #103

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Godot4 #103

merged 1 commit into from
Jun 3, 2023

Conversation

Structed
Copy link
Owner

No description provided.

@Structed Structed self-assigned this Jan 27, 2023
@Structed Structed force-pushed the godot4 branch 3 times, most recently from 0d543e5 to 607f53b Compare June 1, 2023 22:05
@Structed Structed marked this pull request as ready for review June 1, 2023 22:07
# 2. or if GDUnit4 is broken and does not handle siggnals properly yet
func test_login__emits_logged_in_signal_and_returns_LoginResult():
# Test currently broken
return

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi nice to see you using GdUnit now :)
If you run into issues please feel free to create a bugissue, thanks.
https://github.com/MikeSchulze/gdUnit4/issues/new/choose

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply! We briefly talked about this before and I think I was perhaps holding it wrong, I'll try and make a minimal repo soon and report. Cheers!
But if you remove the return and uncomment the connects, you should see that when debugging. the signal is indeed fired and the connected handler is executed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With GdUnit4 v4.1.1 I added the function monitor_signals which allows to monitor for signals.
https://mikeschulze.github.io/gdUnit4/advanced_testing/signals/#monitor-signals

@Structed Structed force-pushed the godot4 branch 2 times, most recently from c674059 to fbfedef Compare June 3, 2023 18:32
BREAKING CHANGE: Update for Godot 4 stable

Upgraded to Godot 4. Thanks to: @MikeSchulze for GDUnit his GH Action workflow examples - https://github.com/MikeSchulze/gdUnit4 @bitbrain for his GH Action workflow examples in https://github.com/bitbrain/beehave

fix(example): Update Events demo scene for Godot 4
fix(example): crash issue on writing telemetry events
ci(pipeline): workflow_dispatch to be in correct indent level
ci(pipeline): Update GDUnit4 actions
ci(pipeline): Run unit tests on Godot 4.02 & 4.0.3
ci(pipeline): Separate Godot 4 & 3 branches
ci(pipeline): Separate Godot 4 workflows
ci(pipeline): set new asset ID for new Asset in AssetLib
ci(pipeline): Exclude LoginIntegrationTest (broken)
ci(pipeline): Removed defunct & unused plugin refresher
test(pipeline): Switch test framework to GDUnit4
docs(readme): Added users of godot-playfab to README.md
docs(license)Updated licenses
@Structed Structed merged commit 0d39b88 into develop Jun 3, 2023
8 checks passed
@Structed Structed deleted the godot4 branch June 3, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants