Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed calls to POST /v2/deliveries/{delivery_id}/cancel #15

Merged
merged 6 commits into from Oct 5, 2020
Merged

Fixed calls to POST /v2/deliveries/{delivery_id}/cancel #15

merged 6 commits into from Oct 5, 2020

Conversation

williamcoates
Copy link
Contributor

  • gracefully handle empty response body
  • assume all 2xx responses are successful

Resolves #13

@luisgregson luisgregson mentioned this pull request Sep 29, 2020
Closed
JoseHervas
JoseHervas approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@JoseHervas JoseHervas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoseHervas JoseHervas merged commit f8ffe61 into StuartApp:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseHervas JoseHervas JoseHervas approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POST /v2/deliveries/{delivery_id}/cancel fails because response body undefined
2 participants
@williamcoates @JoseHervas