Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice thrown with php 7.1 #2104

Closed
tseho opened this issue Jul 17, 2017 · 1 comment
Closed

Notice thrown with php 7.1 #2104

tseho opened this issue Jul 17, 2017 · 1 comment
Assignees

Comments

@tseho
Copy link

tseho commented Jul 17, 2017

Hey, I'm having this notice thrown with php 7.1:

Notice: A non well formed numeric value encountered in /app/vendor/studio-42/elfinder/php/elFinder.class.php at line 3632

https://github.com/Studio-42/elFinder/blob/2.1.26/php/elFinder.class.php#L3632

I'm using php:7.1-fpm with xdebug.

Before 7.1,

$val = "128M";
$val *= 1024;
var_dump($val); // int(131072)

Since 7.1,

$val = "128M";
$val *= 1024; // Notice thrown
var_dump($val); // int(131072)

In my case, It's only happening since 2.1.25 because getIniBytes() was not called before.

A solution would be to cast to int before the switch.

@nao-pon nao-pon self-assigned this Jul 18, 2017
@nao-pon
Copy link
Member

nao-pon commented Jul 18, 2017

@tseho Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants