Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser extension conflicting with ElFinder #2337

Closed
kagagnon opened this issue Dec 19, 2017 · 3 comments
Closed

Browser extension conflicting with ElFinder #2337

kagagnon opened this issue Dec 19, 2017 · 3 comments
Assignees

Comments

@kagagnon
Copy link

This issue has been documented in another thread on the Backpack for Laravel repository: Laravel-Backpack/CRUD#389

When opening the ElFinder, I receive the following error in the console: elfinder debug: [error] [elfinder] Unable to open "#".<br>Folder not found. Upon inspection, I've found the problem.

On the line 3895 of elFinder.js, there is an event bound on the window called message which call an additional request. When calling a new request, it aborts current requests of type open.

Now, some extensions installed on Chrome, Grammarly in my case, can cause problems. That extension was triggering the event message on page load, aborting the initial request of elFinder. When it was doing the .sync, the target param sent in get was empty, causing the error.

Now, the fix was easy, disabling the extension solved everything, but it is not practical. Would using a less generic name or a prefix instead of a namespace for the event be possible? It would solve that problem at least.

@nao-pon nao-pon self-assigned this Dec 20, 2017
@nao-pon
Copy link
Member

nao-pon commented Dec 20, 2017

@kagagnon This is a elFinder's bug. so I'll fix it.

Thanks! 👍

@nao-pon
Copy link
Member

nao-pon commented Dec 20, 2017

@kagagnon Probably, it was fixed on 08f801a. Please check with nightly build.

@kagagnon
Copy link
Author

It indeed is fixed, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants