Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there hard coding ?? i18n #2706

Closed
johnfort opened this issue Oct 11, 2018 · 3 comments
Closed

Why is there hard coding ?? i18n #2706

johnfort opened this issue Oct 11, 2018 · 3 comments
Assignees

Comments

@johnfort
Copy link

24298 helpSource = fm.baseUrl + 'js/i18n/help/%s.html.js';
4472 langJs = self.baseUrl + 'js/i18n/elfinder.' + lang + '.js',

@johnfort
Copy link
Author

I created an option to switch languages. i18nPath.
But I do not know how to add this to help files.
Help me.

@johnfort
Copy link
Author

uiCmdMapPrev = '',
gcJobRes = null,
i18nPath = 'js/i18n/',
...
this.i18nPath = i18nPath;
...
if (this.options.i18nPath) {
i18nPath = this.options.i18nPath;
this.i18nPath = this.options.i18nPath;
}
...
langJs = i18nPath + 'elfinder.' + lang + '.js',
...
helpSource = fm.i18nPath + 'help/%s.html';

It's true ??? Working...

@nao-pon
Copy link
Member

nao-pon commented Oct 12, 2018

@fortcms I'll add an option i18nBaseUrl. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants