Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preference need restructure #2731

Closed
johnfort opened this issue Oct 19, 2018 · 5 comments
Closed

Preference need restructure #2731

johnfort opened this issue Oct 19, 2018 · 5 comments

Comments

@johnfort
Copy link

johnfort commented Oct 19, 2018

Lang, dialog, reset grouped by Other. Delete icons size...
opera _2018-10-19_172629_localhost
and I want hide any conf

@nao-pon
Copy link
Member

nao-pon commented Oct 20, 2018

@fortcms I'll add command option width and height. And you can hide any preferences with an option prefs.

see https://github.com/Studio-42/elFinder/blob/master/js/commands/preference.js#L32

@johnfort
Copy link
Author

@nao-pon I known about it (https://github.com/Studio-42/elFinder/blob/master/js/commands/preference.js#L32)
If you add more settings in the future, I may not know about them.
I want to specify only hidden settings.

@johnfort
Copy link
Author

johnfort commented Oct 20, 2018

I believe that the size of the icons here is not needed. Or add sorting ..

Why don't you want to regroup config?
Variable height is also not a good idea.

@nao-pon
Copy link
Member

nao-pon commented Oct 20, 2018

It is meaningful to be able to remember it because you can change the icon size. In addition, the last value is saved automatically for sorting. As for the dialog size, there are many items on the All tab and it is meaningful that the user can change the size of the dialog.

Also, group change can be changed by setting.

@nao-pon
Copy link
Member

nao-pon commented Oct 20, 2018

If you need your own configuration dialog, you can replace the default command with the connector setting.

'uiCmdMap' => array('preference' => 'mypreference')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants